Analysis Details

When you catch an exception to throw a new higher-level one, make sure to set the original exception as the cause.

es.uniovi.reflection.analyses.bloch.9.61.2

This rule detects methods that may throw a checked exception whose particular type is not declared in the throws clause (because a supertype is declared to be thrown instead).

Computational Reflection Research Group

12-03-2025 17:14

Bad Practice

Throw Statement

MATCH (catchParam)<-[:CATCH_VARIABLE]-(catch:CATCH_CLAUSE)-[:CATCH_BLOCK]->()-[:BLOCK_ENCLOSES | CASE_STATEMENT | CASE_BODY | DO_WHILE_STATEMENT | FOREACH_STATEMENT | FOR_LOOP_STATEMENT | IF_THEN | IF_ELSE | LABELED_STATEMENT_ENCLOSES | SWITCH_CASE | SYNCHRONIZED_BLOCK | TRY_BLOCK | TRY_FINALLY | WHILE_STATEMENT*]->(throw:THROW_STATEMENT)-[:THROW_EXPR]->(newInstance:NEW_INSTANCE) 
  WHERE NOT EXISTS((newInstance)-[:NEW_INSTANCE_ARG]->()<-[:USED_BY]-(catchParam))
WITH es.uniovi.reflection.codeanalysis.functions.getEnclosingType(catch) as enclType, throw, catchParam, catch
MATCH (cu:ORDINARY_CU)-[:HAS_NESTED_TYPE | DECLARES_TYPE]->(enclType)
RETURN '{"node":"THROW STATEMENT","line":"'+throw.lineNumber+'","column":"'+throw.column+'","rule":"BLOCH-9.61.2","location":"'+cu.fileName+'","message":"The exception thrown at line ' + throw.lineNumber + ' in type ' + enclType.fullyQualifiedName +  ' is inside a catch (line ' + catch.lineNumber + ') but it does not have the original catched exception ' + catchParam.name + 'as cause."}'